Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

"option" objects should extend js.Object & ClusterSettings.serialization should be optional #281

Merged
merged 4 commits into from
Jun 23, 2020
Merged

"option" objects should extend js.Object & ClusterSettings.serialization should be optional #281

merged 4 commits into from
Jun 23, 2020

Conversation

exoego
Copy link
Owner

@exoego exoego commented Jun 21, 2020 •
edited
Loading

https://nodejs.org/dist/latest-v14.x/docs/api/cluster.html#cluster_cluster_settings
serialization Specify the kind of serialization used for sending messages between processes. Possible values are 'json' and 'advanced'. See Advanced Serialization for child_process for more details. Default: false.

@exoego exoego added the bug Something isn't working label Jun 21, 2020
@exoego exoego changed the title Fix "option" objects to use Factory macro Fix "option" objects Jun 21, 2020
@exoego exoego mentioned this pull request Jun 21, 2020
Closed
@exoego exoego changed the title Fix "option" objects Fix "option" objects do not extend js.Object & ClusterSettings.serialization should be optional Jun 21, 2020
@exoego exoego changed the title Fix "option" objects do not extend js.Object & ClusterSettings.serialization should be optional "option" objects should extend js.Object & ClusterSettings.serialization should be optional Jun 21, 2020
@exoego exoego marked this pull request as draft June 21, 2020 13:58
@exoego
Copy link
Owner Author

exoego commented Jun 21, 2020

Waiting 0.2.1 of https://github.com/exoego/scalajs-types-util published

@exoego exoego marked this pull request as ready for review June 23, 2020 01:06
@exoego exoego merged commit b6f7c73 into master Jun 23, 2020
@exoego exoego deleted the factory-update branch June 23, 2020 01:06
@exoego exoego mentioned this pull request Jun 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@exoego